Vjp/refactor player pt2 #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 10, 2022 21:14
A lot of this is just shuffling stuff around but it does make the code a bit more self-documenting. handleAssign could probably be factored further but we don't want this to get too out of hand..
|
Yeah there's definitely some problems with my parser code here. It also looked like there's an undefined |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors all the global variable setting code into its own function, and then breaks that function down into a number of sub functions just to clean it up a little.
You can review this commit by commit if you wanna see the individual changes. It's not too crazy though
Something im curious about:
In the function
adjust_operands, we have this lineIt looks like these are local variables but weren't being used anywhere. If they're used in some broader context, then perhaps factoring the
handle_assignfunction could've broke something? In testing, all of the%commands still seem to be working, but this might need some fixing up if not.