Skip to content

Vjp/refactor player pt2 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 22, 2022
Merged

Vjp/refactor player pt2 #10

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0627f10
Pull variable set handler into its own function
Jan 10, 2022
fa52e5b
Move operator reading into its own function
Jan 10, 2022
19ee1dc
Factor out operator handling functions
Jan 13, 2022
0865450
Merge branch 'develop' into vjp/refactor-player-pt2
Jan 13, 2022
a33d40f
Add end of file newline >_<
Jan 13, 2022
974a2ae
Fix function naming convention
Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'develop' into vjp/refactor-player-pt2
  • Loading branch information
Vance Palacio committed Jan 13, 2022
commit 0865450164d2ac258ccf637e302d19b2ca3cc63e
9 changes: 1 addition & 8 deletions textbeat/player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1980,13 +1980,6 @@ def adjustOperands(val: str, op:str) -> tuple[str,str]:
else: assert False # no such op

if var=='T':
if self.midifile:
if not self.midifile.tracks:
self.midifile.tracks.append(mido.MidiTrack())
self.midifile.tracks[0].append(mido.MetaMessage(
'set_tempo', tempo=mido.bpm2tempo(int(
val.split('x')[0]
))
))
self.write_midi_tempo(int(val.split('x')[0]))
self.row += 1
return LoopResult.CONTINUE
You are viewing a condensed version of this merge commit. You can view the full changes here.