Skip to content

[BUG] unity-jar-resolver fails if the classifier doesn't have artifactType attached #422

Closed
@bhbac-nhnent

Description

@bhbac-nhnent

[REQUIRED] Please fill in the following fields:

  • Unity editor version: 2020.1.11f1
  • External Dependency Manager version: v1.2.164
  • Source you installed EDM4U: external-dependency-manager-1.2.164.unitypackage
  • Features in External Dependency Manager in use: Android Resolver
  • Plugins SDK in use: Not use
  • Platform you are using the Unity editor on: Windows 10 64bit

[REQUIRED] Please describe the issue here:

Please answer the following, if applicable:

What's the issue repro rate?

  • 100%

Hi.

In #416 , you guys modified the unity-jar-resolver to be able to identify the classifier as well.
But unfortunately, after some testing, I found out that the functionality was not fully implemented yet.

In gradle, '@ + artifactType' means 'dependency is ignored'.
See an example below how it works in gradle.

WITH DEPENDENCIES
image
WITHOUT DEPENDENCIES
image

However, unity-jar-resolver fails if the classifier doesn't have artifactType attached.
This is not the correct behavior.

SUCCESS

<dependencies>
  <androidPackages>
    <androidPackage spec="com.sina.weibo.sdk:core:10.10.0:openDefaultRelease@aar">
      <repositories>
        <repository>https://dl.bintray.com/thelasterstar/maven</repository>
      </repositories>
    </androidPackage>
  </androidPackages>
</dependencies>

FAIL

<dependencies>
  <androidPackages>
    <androidPackage spec="com.sina.weibo.sdk:core:10.10.0:openDefaultRelease">
      <repositories>
        <repository>https://dl.bintray.com/thelasterstar/maven</repository>
      </repositories>
    </androidPackage>
  </androidPackages>
</dependencies>

image

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions