[BUG] unity-jar-resolver fails if the classifier doesn't have artifactType attached

[bhbac-nhnent]

[REQUIRED] Please fill in the following fields:

• Unity editor version: 2020.1.11f1
• External Dependency Manager version: v1.2.164
• Source you installed EDM4U: external-dependency-manager-1.2.164.unitypackage
• Features in External Dependency Manager in use: Android Resolver
• Plugins SDK in use: Not use
• Platform you are using the Unity editor on: Windows 10 64bit

[REQUIRED] Please describe the issue here:

Please answer the following, if applicable:

What's the issue repro rate?

• 100%

Hi.

In #416 , you guys modified the unity-jar-resolver to be able to identify the classifier as well.
But unfortunately, after some testing, I found out that the functionality was not fully implemented yet.

In gradle, '@ + artifactType' means 'dependency is ignored'.
See an example below how it works in gradle.

WITH DEPENDENCIES

WITHOUT DEPENDENCIES

However, unity-jar-resolver fails if the classifier doesn't have artifactType attached.
This is not the correct behavior.

SUCCESS

<dependencies>
  <androidPackages>
    <androidPackage spec="com.sina.weibo.sdk:core:10.10.0:openDefaultRelease@aar">
      <repositories>
        <repository>https://dl.bintray.com/thelasterstar/maven</repository>
      </repositories>
    </androidPackage>
  </androidPackages>
</dependencies>

FAIL

<dependencies>
  <androidPackages>
    <androidPackage spec="com.sina.weibo.sdk:core:10.10.0:openDefaultRelease">
      <repositories>
        <repository>https://dl.bintray.com/thelasterstar/maven</repository>
      </repositories>
    </androidPackage>
  </androidPackages>
</dependencies>

[google-oss-bot]

This issue does not seem to follow the issue template. Make sure you provide all the required information.

[vimanyu]

Hi @bhbac-nhnent,
Thanks for creating this issue. I did not see many examples of package specification with classifiers and added the feature with the example which had an artifact type. Will look into implementing support for this.

[bhbac-nhnent]

@vimanyu I'm sorry. It seems I haven't properly verified it.
I checked the screenshot and found that the weibo-sdk module does not exist when there is no @aar definition, so I tested again.
As a result, it was confirmed that an error occurred even in gradle.

So, I don't think there is any problem with the current behavior of unity-jar-resolver, and I think you can close this issue here.
I am sorry again for reporting unnecessary issues.

Thanks!

[vimanyu]

Oh, no worries. Thanks for creating these detailed issues with all the information. I am going to close this ticket. I still think the support is limited to classifiers with artifact types specified but if you are unable to use an android package with such specification, feel free to create a ticket.