Skip to content

remove temporary redirect for swapi-graphql, use netlify 200 rewrite #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

acao
Copy link
Member

@acao acao commented Jun 10, 2019

@caniszczyk this should be a more permanent solution? what do you think?

@@ -0,0 +1 @@
/swapi-graphql https://graphql.github.io/swapi-graphql 200
Copy link
Contributor

@JoelMarcey JoelMarcey Jun 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, as a 200 netlify rewrite, looks similar to an apache .htaccess rewrite rule or nginx proxy_pass rule

@JoelMarcey JoelMarcey merged commit 97efd37 into graphql:source Jun 10, 2019
@acao
Copy link
Member Author

acao commented Jun 10, 2019

thanks @JoelMarcey !

Dipeshwagle pushed a commit to Dipeshwagle/graphql.github.io that referenced this pull request Aug 18, 2020
remove temporary redirect for swapi-graphql, use netlify 200 rewrite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants