Skip to content

remove temporary redirect for swapi-graphql, use netlify 200 rewrite #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/fileWalker.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module.exports = fileWalker;
var IGNORE_RX =
/^(?:_|\.|(?:node_modules|package\.json|README\.(?:md|markdown))$)/;

var INCLUDE_RX = /^(?:\.nojekyll|\.htaccess)/;
var INCLUDE_RX = /^(?:\.nojekyll|\.htaccess|\_redirects)/;

function fileWalker(dirPath, onVisitFile) {
return new Promise((resolve, reject) => {
Expand Down
1 change: 1 addition & 0 deletions site/_redirects
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/swapi-graphql https://graphql.github.io/swapi-graphql 200
Copy link
Contributor

@JoelMarcey JoelMarcey Jun 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, as a 200 netlify rewrite, looks similar to an apache .htaccess rewrite rule or nginx proxy_pass rule

3 changes: 0 additions & 3 deletions site/swapi-graphql/index.html.js

This file was deleted.