Skip to content

Fix import of express-graphql #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 19, 2020
Merged

Conversation

RitikDua
Copy link
Contributor

@RitikDua RitikDua commented Jul 26, 2020

Fixed a syntax error during the destruction of function "graphqlHTTP".

RitikDua added 4 commits July 27, 2020 01:57
Fixed a bug, It might be a typo.
Copy link
Member

@carolstran carolstran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care @RitikDua 💫

My only suggestion would be to add spaces between the graphqlHTTP and the brackets (ie { graphqlHTTP } instead of the existing {graphqlHTTP}) to keep the style consistent with the other imports.

Pinging @IvanGoncharov - this PR is similar to #905, but updates more instances of the import error. Also closes #895.

@RitikDua
Copy link
Contributor Author

RitikDua commented Aug 19, 2020

Thanks for taking care @RitikDua dizzy

My only suggestion would be to add spaces between the graphqlHTTP and the brackets (ie { graphqlHTTP } instead of the existing {graphqlHTTP}) to keep the style consistent with the other imports.

Pinging @IvanGoncharov - this PR is similar to #905, but updates more instances of the import error. Also closes #895.

Thanks @carolstran for reviewing it and i also completed the changes you suggested,.

@IvanGoncharov IvanGoncharov changed the title Update Tutorial-BasicTypes.md Fix express-graphql imports Aug 19, 2020
@IvanGoncharov IvanGoncharov changed the title Fix express-graphql imports Fix import of express-graphql. Aug 19, 2020
@IvanGoncharov IvanGoncharov changed the title Fix import of express-graphql. Fix import of express-graphql Aug 19, 2020
@IvanGoncharov IvanGoncharov merged commit 2ad9fc7 into graphql:source Aug 19, 2020
ardatan added a commit to ardatan/graphql.github.io that referenced this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants