Fix import error in GraphQL.js sample code #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed graphqlHTTP to { graphqlHTTP }
carolstran
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Looks good, thanks for taking care of this @AmmonMatthews! Also closes #895.
My only note would be to update the commit message to give a bit more context (ie. Fix import error in GraphQL.js sample code instead of Changed line 21) - but that could happen when merging.
Pinging @IvanGoncharov to merge 😊
IvanGoncharov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed graphqlHTTP to { graphqlHTTP }. It was erroring out and doesn't look like it is a default export but a named export from the error I received saying TypeError: graphqlHTTP is not a function