Skip to content

Conversation

Mohamed-Asar
Copy link
Contributor

@Mohamed-Asar Mohamed-Asar commented Aug 3, 2024

Description (*)

Ui component file field required field validation bug fix

Fixed Issues (if relevant)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Aug 3, 2024

Hi @Mohamed-Asar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Aug 3, 2024
@m2-github-services m2-github-services added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Aug 3, 2024
@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests

@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Dec 11, 2024
@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel requested a review from mrtuvn December 18, 2024 11:05
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Static Tests, Unit Tests

@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests

@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Dec 19, 2024
@engcom-Dash engcom-Dash self-assigned this Dec 20, 2024
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

Hi @Mohamed-Asar,

Thanks for the collaboration & contribution!

✔️ QA Passed
Preconditions:

Install fresh Magento 2.4-develop
Steps to reproduce

  • As per the issue's description.

Before: ✖️
image

After: ✔️
image

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Dash
Copy link
Contributor

@magento run Unit Tests, Static Tests, Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Unit Tests, Static Tests, Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@engcom-Hotel: I have made a change to the doc comment: @param {ImageUploader} imageUploader - UI Class has been changed to @param {FileUploader} fileUploader - UI Class (here). Could you please review it?

Note: The static tests are not failing due to the PR changes. Here is the Jira.

cc: @Mohamed-Asar

@engcom-Hotel
Copy link
Contributor

@magento run Static Tests, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Unit Tests, Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

The Functional B2B, CE, and EE test failures have been inconsistent or are known issues in the last two builds and seem to be flaky. Failed integration tests can also be seen in other PRs (see here). They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Integration Tests
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39004/8c8ea70d235e78043939368346c75e40/Integration/console-error-logs.html
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39004/10e4e6f2cdba1cc898bb7b159b24f5b8/Integration/console-error-logs.html
image

Functional Tests B2B
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39004/e02b41fdc4312bf6f4d451301e0a0f92/Functional/allure-report-b2b/index.html#categories/76effb04c71458640753efa402b62626/73dce576553749e8/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39004/fc36ffaeeba096277772acb8be310962/Functional/allure-report-b2b/index.html#categories/2fc037f47773dd7551f2e766bbf34efa/8904b9e72d3b5885/
image

Known Issue:
StorefrontAssertAvailableShippingRateIsChangedBasedOnInputedDataTest: ACQE-7380

Functional Tests CE
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39004/8635a98e87ada08d8a54db88cc77e054/Functional/allure-report-ce/index.html#categories/e93c564a2dcd5e30ee0e0e811a828c2b/8b59166543953ffc/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39004/db9a186246db506564bcf4880d7e7324/Functional/allure-report-ce/index.html#categories/e93c564a2dcd5e30ee0e0e811a828c2b/ab228262e31a94a0/
image

Known Issues:
StorefrontAssertAvailableShippingRateIsChangedBasedOnInputedDataTest: ACQE-7380
StorefrontCreateCustomerWithInvalidDataTest: ACQE-7384

Functional Tests EE
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39004/d3d604269cfc91f4b8abda16411b63d4/Functional/allure-report-ee/index.html#categories/f52ee74d047ab5dac5b0f95b98cfbada/b9a774df6493df42/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39004/1b33b51d1893856a446477223d1857a6/Functional/allure-report-ee/index.html#categories/d72680ba14c85277305c91e190a1f53b/8284954a14f61f08/
image

Known Issue:
StorefrontAssertAvailableShippingRateIsChangedBasedOnInputedDataTest: ACQE-7380

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit d6856a5 into magento:2.4-develop Jan 7, 2025
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Project: Community Picked PRs upvoted by the community Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Projects

Status: Recently Merged

Development

Successfully merging this pull request may close these issues.

Ui Component File Field

7 participants