Skip to content

AC-12432, Issue-38908 Input type file required field validation bug fix #39004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 7, 2025
Merged

AC-12432, Issue-38908 Input type file required field validation bug fix #39004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8e2ce8b
AC-12432, Issue-38908 Input type file required field validation bug fix
Mohamed-Asar Aug 3, 2024
ef53fff
Merge branch '2.4-develop' into bug/AC-12432-file-required-validation
Mohamed-Asar Aug 3, 2024
d9e25cd
Merge branch '2.4-develop' into bug/AC-12432-file-required-validation
engcom-Hotel Dec 18, 2024
f441a5b
Coding standard fix
Mohamed-Asar Dec 19, 2024
7fd26dc
Merge branch 'bug/AC-12432-file-required-validation' of https://githu…
Mohamed-Asar Dec 19, 2024
2732049
Merge branch '2.4-develop' into bug/AC-12432-file-required-validation
engcom-Dash Dec 20, 2024
18f2006
Merge branch '2.4-develop' into bug/AC-12432-file-required-validation
engcom-Dash Dec 23, 2024
dfab282
39004: fix static failures
engcom-Dash Dec 23, 2024
0642049
39004: remove extra space
engcom-Dash Dec 23, 2024
24f10d4
Merge branch '2.4-develop' into bug/AC-12432-file-required-validation
engcom-Dash Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions app/code/Magento/Ui/view/base/web/js/form/element/media.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2015 Adobe
* All Rights Reserved.
*/

/**
Expand All @@ -14,6 +14,7 @@ define([

return Abstract.extend({
defaults: {
value: '',
links: {
value: ''
}
Expand Down Expand Up @@ -47,6 +48,16 @@ define([
this.formId = namespace[0];

return this;
},

/**
* Set the file input value
*
* @param {FileUploader} fileUploader - UI Class
* @param {Event} e
*/
setFileValue: function (fileUploader, e) {
this.value(e.target.files.length ? e.target.files.length : '');
}
});
});
12 changes: 6 additions & 6 deletions app/code/Magento/Ui/view/base/web/templates/form/element/media.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
/**
* Copyright 2011 Adobe
* All Rights Reserved.
*/
-->
<input class="admin__control-file" type="file" data-bind="
hasFocus: focused,
Expand All @@ -13,5 +13,5 @@
id: uid,
disabled: disabled,
form: formId
}"
/>
}, event:{change: setFileValue}"
>