Skip to content

BugFix: IE11 powerbi.reset() doesn't work #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2017
Merged

BugFix: IE11 powerbi.reset() doesn't work #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77228fa
Fix for: https://github.com/Microsoft/PowerBI-JavaScript/issues/173
Mar 16, 2017
531ef43
Fix for: https://github.com/Microsoft/PowerBI-JavaScript/issues/173
Mar 16, 2017
d797cca
Code formatting.
Mar 16, 2017
9b1e0c2
Revert "Fix for: https://github.com/Microsoft/PowerBI-JavaScript/issu…
Mar 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export class Service implements IService {
/**
* A list of components that this service can embed
*/
private static components: (typeof Report | typeof Tile | typeof Dashboard)[] = [
private static components: (typeof Report | typeof Tile | typeof Dashboard)[] = [
Tile,
Report,
Dashboard
Expand Down Expand Up @@ -170,7 +170,7 @@ export class Service implements IService {
let powerBiElement = <IPowerBiElement>element;
const component = new Create(this, powerBiElement, config);
powerBiElement.powerBiEmbed = component;

this.addOrOverwriteEmbed(component, element);

return component;
Expand Down Expand Up @@ -266,11 +266,11 @@ export class Service implements IService {
/**
* When loading report after create we want to use existing Iframe to optimize load period
*/
if(config.type === "report" && component.config.type === "create") {
if (config.type === "report" && component.config.type === "create") {
const report = new Report(this, element, config, element.powerBiEmbed.iframe);
report.load(<embed.IInternalEmbedConfiguration>config);
element.powerBiEmbed = report;

this.addOrOverwriteEmbed(component, element);

return report;
Expand Down Expand Up @@ -323,7 +323,7 @@ export class Service implements IService {

addOrOverwriteEmbed(component: embed.Embed, element: HTMLElement): void {
// remove embeds over the same div element.
this.embeds = this.embeds.filter(function(embed) {
this.embeds = this.embeds.filter(function (embed) {
return embed.element.id !== element.id;
});

Expand All @@ -350,7 +350,12 @@ export class Service implements IService {
/** Removes the iframe from the element. */
const iframe = element.querySelector('iframe');
if (iframe) {
iframe.remove();
if (iframe.remove !== undefined) {
iframe.remove();
} else {
// workaround for IE: Unhandled rejection TypeError: object doesn't support property or method 'remove'
iframe.parentElement.removeChild(iframe);
}
}
}

Expand Down
8 changes: 4 additions & 4 deletions tslint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"extends": "tslint:recommended",
"rules": {
"max-line-length": false,
"max-line-length": [false],
"member-access": false,
"no-console": false,
"no-console": [false],
"one-line": [
"check-whitespace",
"check-open-brace"
Expand All @@ -12,13 +12,13 @@
"single",
"avoid-escape"
],
"trailing-comma": false,
"trailing-comma": [false],
"whitespace": [
"check-branch",
"check-decl",
"check-operator",
"check-module",
"check-seperator",
"check-separator",
"check-type"
],
"object-literal-sort-keys": false
Expand Down