-
Notifications
You must be signed in to change notification settings - Fork 722
wire up @ts-nocheck/ts-check pragmas #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ahejlsberg I think you're working on pragma parsing, not sure what you're modifying at this point, though. Maybe it'd be fine to take this and you just delete the ported code in favor of your regex-free version? |
This seems correct to me, just, bad timing with Anders porting more pragma code for JSX. |
Co-authored-by: Jake Bailey <[email protected]>
If this is in-progress I'm happy to wait. Support for |
Er, well, we don't have JSDoc support, so JS support is going to be wonky at best. |
Even though tests are passing locally, when I try using the built tsgo on my project.. its still reporting errors for files with |
Alright I have this working to my satisfaction. If there are other PRs I need to resolve merge conflicts against, lmk. |
does not respect @ts-nocheck marked files in a project without this for some reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
follow up to #719
cc @jakebailey