Skip to content

Conversation

tmm1
Copy link
Contributor

@tmm1 tmm1 commented Apr 1, 2025

follow up to #719

cc @jakebailey

@jakebailey
Copy link
Member

@ahejlsberg I think you're working on pragma parsing, not sure what you're modifying at this point, though. Maybe it'd be fine to take this and you just delete the ported code in favor of your regex-free version?

@jakebailey
Copy link
Member

This seems correct to me, just, bad timing with Anders porting more pragma code for JSX.

Co-authored-by: Jake Bailey <[email protected]>
@tmm1
Copy link
Contributor Author

tmm1 commented Apr 1, 2025

If this is in-progress I'm happy to wait. Support for @ts-nocheck is the only thing preventing me from using tsgo atm.

@jakebailey
Copy link
Member

If this is in-progress I'm happy to wait. Support for @ts-nocheck is the only thing preventing me from using tsgo atm.

Er, well, we don't have JSDoc support, so JS support is going to be wonky at best.

@tmm1
Copy link
Contributor Author

tmm1 commented Apr 1, 2025

Even though tests are passing locally, when I try using the built tsgo on my project.. its still reporting errors for files with // @ts-nocheck at the top. Not immediately clear to me why.

@tmm1
Copy link
Contributor Author

tmm1 commented Apr 1, 2025

Alright I have this working to my satisfaction. If there are other PRs I need to resolve merge conflicts against, lmk.

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@jakebailey jakebailey closed this Apr 7, 2025
@jakebailey jakebailey reopened this Apr 7, 2025
@jakebailey jakebailey enabled auto-merge April 7, 2025 22:27
@jakebailey jakebailey added this pull request to the merge queue Apr 7, 2025
Merged via the queue into microsoft:main with commit 5d718ec Apr 7, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants