Return empty diags for files with skipped checking

[jakebailey]

This mirrors getBindAndCheckDiagnosticsForFileNoCache, which looks like:

    function getBindAndCheckDiagnosticsForFileNoCache(
        sourceFile: SourceFile,
        cancellationToken: CancellationToken | undefined,
        nodesToCheck?: Node[],
    ): readonly Diagnostic[] {
        return runWithCancellationToken(() => {
            if (skipTypeChecking(sourceFile, options, program)) {
                return emptyArray;
            }

            const typeChecker = getTypeChecker();

Notably I am not doing this in getBindDiagnosticsForFile since that isn't actually called by anyone except tsgo for timing.

This fixes the baseline checks that were commented out in #762.

[Copilot]

Copilot reviewed 3 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (10)

• testdata/baselines/reference/submodule/compiler/intersectionsOfLargeUnions2.errors.txt: Language not supported
• testdata/baselines/reference/submodule/compiler/intersectionsOfLargeUnions2.errors.txt.diff: Language not supported
• testdata/baselines/reference/submodule/compiler/requireOfJsonFileWithComputedPropertyName.errors.txt: Language not supported
• testdata/baselines/reference/submodule/compiler/requireOfJsonFileWithComputedPropertyName.errors.txt.diff: Language not supported
• testdata/baselines/reference/submodule/conformance/plainJSRedeclare3.errors.txt: Language not supported
• testdata/baselines/reference/submodule/conformance/plainJSReservedStrict.errors.txt: Language not supported
• testdata/baselines/reference/submodule/conformance/ts-expect-error-nocheck-js.errors.txt: Language not supported
• testdata/baselines/reference/submoduleAccepted/conformance/plainJSRedeclare3.errors.txt.diff: Language not supported
• testdata/baselines/reference/submoduleAccepted/conformance/plainJSReservedStrict.errors.txt.diff: Language not supported
• testdata/baselines/reference/submoduleAccepted/conformance/ts-expect-error-nocheck-js.errors.txt.diff: Language not supported

Comments suppressed due to low confidence (1)

internal/checker/utilities.go:1783

• Ensure that replacing tspath.IsDeclarationFileName(sourceFile.FileName()) with sourceFile.IsDeclarationFile provides the same behavior in all scenarios. It is important that this change does not inadvertently affect the logic for identifying declaration files.

func SkipTypeChecking(sourceFile *ast.SourceFile, options *core.CompilerOptions) bool {

[ahejlsberg]

When and why would we restore this? Seems odd for skipLibChecks to affect binding.

[jakebailey]

We have one function that gets both bind and check diagnostics (getBindAndCheckDiagnosticsForFileNoCache), and it's silenced by this same function in Strada. Why? I have no idea, but that's how it was. It's just that they are split apart in Corsa for timing reasons at the moment.