__cplusplus value should not be used to decide for std::unique_ptr #350: #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en-source-parsers#350: In addition to the C++ language version define __cplusplus also check _CPPLIB_VER for better Dinkumware support.
|
I lost track of the conversation on this. Was there any objection? If not, could you rebase this to the current tip of |
…issue-350-unique_ptr
|
I'm not aware of any objections. Should I select "Close and comment" instead of "Comment" to signal that I'm happy? |
|
That looks like a merge-commit. Could you rebase? If you don't know how, that's fine. I can do it. |
|
I just learned the difference between rebase and merge commits: |
|
OK, I'll try a rebase this evening. |
|
I was busy the last two days, but please let my try to that on my own during the weekend. |
|
Replaced by the rebased pull request #367 |
|
Note that you can rebase a pull-request without opening a new one: GitHub would magically update this PR. It's a nice feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the C++ language version define __cplusplus also check _CPPLIB_VER for better Dinkumware support.