__cplusplus value should not be used to decide for std::unique_ptr #350: #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en-source-parsers#350: In addition to the C++ language version define __cplusplus also check _CPPLIB_VER for better Dinkumware support.
|
Hopefully this rebased pull request is more appealing. |
cdunn2001
added a commit
that referenced
this pull request
Sep 28, 2015
__cplusplus value should not be used to decide for std::unique_ptr resolves #350
|
Sweet! I think we can even apply this to the 0.y.z branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the C++ language version define __cplusplus also check _CPPLIB_VER for better Dinkumware support.