Skip to content

Fix missing initialization in Constructor. #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ya1gaurav
Copy link
Contributor

OurFeatures() Constructor is not initializing variable rejectDupKeys_.

OurFeatures() Constructor is not initializing variable rejectDupKeys_.
@pavel-pimenov
Copy link
Contributor

cppcheck 1.69
Member variable 'OurFeatures::stackLimit_' is not initialized in the constructor.
Member variable 'OurReader::stackDepth_' is not initialized in the constructor.

@BillyDonahue
Copy link
Contributor

pavel has a point. Maybe go a little further and initialize the other fields while we're here.

@ya1gaurav
Copy link
Contributor Author

stackLinit_ initialized in #364
It wil make OurFeatures to be free from above cppcheck , other pull request can be done for OurReader.

@cdunn2001
Copy link
Contributor

Instead, let's delete the whole ctor. We can accept C++ defaults b/c they are always over-ridden in newCharBuilder().

But yes, let's update the OurReader ctor. I don't want to refactor that class since it is mainly a copy of old code.

@cdunn2001 cdunn2001 closed this Sep 22, 2015
cdunn2001 added a commit that referenced this pull request Sep 23, 2015
See #363, similar to #364.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants