Add default value of stackLimit couple of places #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackLimit default value is missing at two places.Adding them.
| @@ -910,6 +910,7 @@ OurFeatures::OurFeatures() | |||
| , allowSingleQuotes_(false) | |||
| , failIfExtra_(false) | |||
| , allowSpecialFloats_(false) | |||
| , stackLimit_(1000) | |||
There was a problem hiding this comment.
Instead of adding this, let's remove this ctor completely. The default is fine, since we always completely over-ride the values in newCharReader().
Please review suggested changes.
cdunn2001
added a commit
that referenced
this pull request
Sep 23, 2015
Have default ctor for OurFeatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stackLimit default value is missing at two places.Adding them.