Replace current install variables with GNUInstallDirs #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strahlc
reviewed
Dec 10, 2016
|
|
||
| # Require C++11 support, prefer ISO C++ over GNU variants, | ||
| # as relying solely on ISO C++ is more portable. | ||
| SET(CMAKE_CXX_STANDARD 11) |
There was a problem hiding this comment.
this feature requires at least cmake 3.1:
You should change line 3 to:
cmake_minimum_required(VERSION 3.1)
|
Can't merge if Travis fails. Maybe there is a way to load the right cmake? |
* The GNUInstallDirs module is more idiomatic and supported by Kitware upstream, whereas the current directories are not standardised across CMake-using packages. Using CMake native mechanisms is better than reinventing the wheel, as it makes using the build system more uniform across the ecosystem * Use CMAKE_CXX_STANDARD to force C++11 * Require CMake 3.1.0 at a minimum * Fixed lower/UPPERcase format for function/macro calls * Fixed indents by replacing tabs with 4 spaces
|
@cdunn2001 I've fixed the CMake error by switching to a newer CMake version, using travis-ci/travis-ci#4631 (comment) |
|
This looks like a lot of work. Thanks! |
|
I have this error: I'll try setting |
|
Oh, it worked after removing the cmake cache. (Actually, I removed the whole build directory and started over.) No problems! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kitware upstream, whereas the current directories are not
standardised across CMake-using packages. Using CMake native
mechanisms is better than reinventing the wheel, as it makes
using the build system more uniform across the ecosystem
This PR is in response to #560