improve: ExternalResourceIDProvider extended to be used in CacheKeyMapper #3007
+17,874
−402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <[email protected]>
this was added to fabric8 client meanwhile Signed-off-by: Attila Mészáros <[email protected]>
) * feature: add AggregatedMetrics to support multiple Metrics implementations Signed-off-by: David Sondermann <[email protected]>
) Co-authored-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]> Co-authored-by: Martin Stefanko <[email protected]>
closes: #2984 Signed-off-by: Steve Hawkins <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
…terEvent (#3003) Signed-off-by: Attila Mészáros <[email protected]> Co-authored-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]> Co-authored-by: Steven Hawkins <[email protected]>
…pper Signed-off-by: Attila Mészáros <[email protected]>
csviri
force-pushed
the
external-resource-id
branch
from
ab4beab to
402bbd6
Compare
xstefank
approved these changes
Oct 23, 2025
There was a problem hiding this comment.
I don't see issues with the PR, but as I said in #3000 (comment) if this is to be redone, is it worth merging it now like this?
|
replaced by: #3019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 5.2 we introduced id provider for external resources:
#2970
This PR extends is to be used also for
ExternalResourceCachingEventSourceand it's subclasses.Also:
ExternalDependentIDProvidertoResourceIDProviderto reflect that is used also for different purpose than dependent resources (event sources). Also having in mind forward compatiblity if we would still want to extend it's scope also for BulkDependentResources