Skip to content

✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) #2268

wants to merge 2 commits into from
+246 −164

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Oct 14, 2025 •
edited
Loading

Description

  • Promote Single Own Feature Gate GA
  • Promote the Config spec to the public/stable API. Without the spec.config.inline.watchNamespace field, there’s no place to declare which namespace the operator should watch, so the controller can only ever assume the default AllNamespaces behaviour. That’s why we need config available in the GA schema: it’s the user-facing knob that flips the controller into Single/Own namespace mode. Example:

    operator-controller/internal/operator-controller/applier/provider_test.go

    Lines 229 to 234 in 9eac616

    Config: &ocv1.ClusterExtensionConfig{
    ConfigType: ocv1.ClusterExtensionConfigTypeInline,
    Inline: &apiextensionsv1.JSON{
    Raw: []byte(`{"watchNamespace": "` + expectedWatchNamespace + `"}`),
    },
    },

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner October 14, 2025 11:22
@openshift-ci openshift-ci bot requested review from joelanford and oceanc80 October 14, 2025 11:22
@camilamacedo86 camilamacedo86 changed the title Promote Single Own Feature Gate to GA ✨ Promote Single Own Feature Gate to GA Oct 14, 2025
@netlify Netlify
Copy link

netlify bot commented Oct 14, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit ea2d9a7
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68f7d6edf5839600074741a2
😎 Deploy Preview https://deploy-preview-2268--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camilamacedo86 camilamacedo86 changed the title ✨ Promote Single Own Feature Gate to GA ✨ Promote Single Own Feature Gate to GA (OPRUN-4098) Oct 14, 2025
@camilamacedo86 camilamacedo86 changed the title ✨ Promote Single Own Feature Gate to GA (OPRUN-4098) WIP: ✨ Promote Single Own Feature Gate to GA (OPRUN-4098) Oct 14, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2025
@camilamacedo86 camilamacedo86 force-pushed the promote-single-own-feature branch from 6ff525c to 6fb12ed Compare October 14, 2025 12:09
@camilamacedo86 camilamacedo86 changed the title WIP: ✨ Promote Single Own Feature Gate to GA (OPRUN-4098) WIP: ✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) Oct 14, 2025
@camilamacedo86 camilamacedo86 changed the title WIP: ✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) ✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) Oct 14, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2025
@camilamacedo86 camilamacedo86 changed the title ✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) WIP: ✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) Oct 14, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2025
@codecov Codecov
Copy link

codecov bot commented Oct 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.47%. Comparing base (85e8cbf) to head (ea2d9a7).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2268      +/-   ##
==========================================
+ Coverage   70.32%   70.47%   +0.15%     
==========================================
  Files          90       90              
  Lines        8794     8794              
==========================================
+ Hits         6184     6198      +14     
+ Misses       2196     2184      -12     
+ Partials      414      412       -2
Flag Coverage Δ
e2e 46.07% <ø> (+8.63%) ⬆️
experimental-e2e 14.10% <ø> (-0.11%) ⬇️
unit 58.34% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86 camilamacedo86 changed the title WIP: ✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) ✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) Oct 14, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2025
tmshort
tmshort reviewed Oct 14, 2025
View reviewed changes
tmshort
tmshort reviewed Oct 14, 2025
View reviewed changes
tmshort
tmshort reviewed Oct 14, 2025
View reviewed changes
tmshort
tmshort reviewed Oct 14, 2025
View reviewed changes
tmshort
tmshort reviewed Oct 14, 2025
View reviewed changes
tmshort
tmshort reviewed Oct 14, 2025
View reviewed changes
tmshort
tmshort reviewed Oct 14, 2025
View reviewed changes
tmshort
tmshort reviewed Oct 14, 2025
View reviewed changes
@camilamacedo86
Copy link
Contributor Author

/hold

We might need to discuss more how to work with see: #2267 (comment)

So it si WIP

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2025
camilamacedo86
camilamacedo86 commented Oct 18, 2025
View reviewed changes
@camilamacedo86
Copy link
Contributor Author

The PR openshift/cluster-olm-operator#144 is merged and all comments addressed so I am

/hold cancel

This one

@tmshort @perdasilva
Could you help us out get this one?

@camilamacedo86
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2025
@perdasilva
Copy link
Contributor

/hold just let me go through the feature again and make sure we're ready for GA

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2025
@tmshort
Copy link
Contributor

tmshort commented Oct 20, 2025

With the Webhook stuff merged, this needs a rebase

@camilamacedo86 camilamacedo86 force-pushed the promote-single-own-feature branch from 6b47340 to b877152 Compare October 21, 2025 07:37
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2025
@camilamacedo86 camilamacedo86 force-pushed the promote-single-own-feature branch from b877152 to 97e8c3f Compare October 21, 2025 08:13
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2025
@camilamacedo86 camilamacedo86 force-pushed the promote-single-own-feature branch 2 times, most recently from 4799e19 to 02c4de7 Compare October 21, 2025 08:21
tmshort
tmshort reviewed Oct 21, 2025
View reviewed changes
tmshort
tmshort reviewed Oct 21, 2025
View reviewed changes
tmshort
tmshort reviewed Oct 21, 2025
View reviewed changes
helm/experimental.yaml Outdated
Comment on lines 12 to 13
- SingleOwnNamespaceInstallSupport
- WebhookProviderCertManager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is now enabled by default, neither of these should be here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed in the rebase

tmshort
tmshort reviewed Oct 21, 2025
View reviewed changes
test/experimental-e2e/boxcutter_support_test.go Outdated
Comment on lines 37 to 51
func TestMain(m *testing.M) {
cfg = ctrl.GetConfigOrDie()

var err error
utilruntime.Must(apiextensionsv1.AddToScheme(scheme.Scheme))
c, err = client.New(cfg, client.Options{Scheme: scheme.Scheme})
utilruntime.Must(err)

os.Exit(m.Run())
}

func TestNoop(t *testing.T) {
t.Log("Running experimental-e2e tests")
defer utils.CollectTestArtifacts(t, artifactName, c, cfg)
}
Copy link
Contributor

@tmshort tmshort Oct 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see this file renamed to experimental_test.go (or similar) and just contain TestMain() and TestNoop(). The Boxcutter tests should be in a separate file.

tmshort
tmshort reviewed Oct 21, 2025
View reviewed changes
helm/tilt.yaml Outdated
Comment on lines 17 to 18
- SingleOwnNamespaceInstallSupport
- WebhookProviderCertManager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are now on by default, so they should be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase sorry

@camilamacedo86 camilamacedo86 force-pushed the promote-single-own-feature branch 2 times, most recently from aa8e960 to a3d83cc Compare October 21, 2025 18:24
@camilamacedo86 camilamacedo86 force-pushed the promote-single-own-feature branch from a3d83cc to ea2d9a7 Compare October 21, 2025 18:54
@tmshort
Copy link
Contributor

tmshort commented Oct 21, 2025

Thank you!
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025
@camilamacedo86
Copy link
Contributor Author

@perdasilva
I will not remove the hold
I will let you to do so when you see that is good enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanford joelanford Awaiting requested review from joelanford

@oceanc80 oceanc80 Awaiting requested review from oceanc80

@perdasilva perdasilva Awaiting requested review from perdasilva

@tmshort tmshort Awaiting requested review from tmshort

1 more reviewer

@michaelryanpeter michaelryanpeter michaelryanpeter left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tmshort tmshort

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@camilamacedo86 @tmshort @perdasilva @pedjak @michaelryanpeter @openshift-merge-robot