Move CODEOWNERS to .github #13591
Move CODEOWNERS to .github #13591
Conversation
The CODEOWNERS file is specific to GitHub interface and can be located in .github, docs or in project root. It makes the php-src root directory a bit more browseable.
|
Lines 1 to 6 in f799d6f I wonder if this information is just useful to GitHub, or also to contributors? |
|
For contributors this file is just noise. They can't message these IDs, it's only to link code with pull requests. Even if someone theoretically will want to know which code to link with some person, the PR does that for them. |
|
I don't have a strong opinion. Feel free to merge if you want. |
|
Although it's the most up to date info about mainteners of the specific parts. Not strong opinion either so I'm fine with this getting moved but might makes sense to sync EXTENSIONS with that so there is at least something a bit more visible. Would be also good to back port this to 8.2 as I'm missing some PR's targeting just that branch... |
|
I see, each branch needs its own CODEOWNERS for this to work. Now this only works for PHP-8.3 and master branches. I'll merge this one to PHP-8.3 and master. And a separate fix for PHP-8.2 with these synced a little what can be done... |
* PHP-8.3: Move CODEOWNERS to .github (#13591)
The CODEOWNERS file is specific to GitHub interface and can be located in .github, docs or in project root. It makes the php-src root directory a bit more browseable.
This repeats the sync as noted in the phpGH-13591 and the discussion https://news-web.php.net/php.internals/124472 The CODEOWNERS file is related to the targeted branch in the pull request and not only the master branch. - CS style comments synced (80 columns length) - Added a note to change the earliest supported PHP branch and not only master branch - Synced GitHub ID's and paths across the PHP-8.2, PHP-8.3 and master branches
This repeats the sync as noted in the phpGH-13591 and the discussion https://news-web.php.net/php.internals/124472 The CODEOWNERS file is related to the targeted branch in the pull request and not only the master branch. - CS style comments synced (80 columns length) - Added a note to change the earliest supported PHP branch and not only master branch - Synced GitHub ID's and paths across the PHP-8.2, PHP-8.3 and master branches
This repeats the sync as noted in the GH-13591 and the discussion https://news-web.php.net/php.internals/124472 The CODEOWNERS file is related to the targeted branch in the pull request and not only the master branch. - Added a note to change the earliest supported PHP branch and not only master branch - Synced GitHub ID's and paths across the PHP-8.2, PHP-8.3 and master branches - Add note how changes here should be analogous to bug fixes with a link to CONTRIBUTING.md which describes which branch to target
While we still can do this ... The CODEOWNERS file is specific to GitHub interface and can be located in .github, docs or in project root. It makes the php-src root directory a bit more browseable.
File was introduced in PHP-8.3 branch: #8670