Skip to content

[skip ci] Sync CODEOWNERS #15017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2024
Merged

[skip ci] Sync CODEOWNERS #15017

merged 3 commits into from
Jul 28, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jul 18, 2024

This repeats the sync as noted in the GH-13591 and the discussion https://news-web.php.net/php.internals/124472

The CODEOWNERS file is related to the targeted branch in the pull request and not only the master branch.

  • CS style comments synced (80 columns length)
  • Added a note to change the earliest supported PHP branch and not only master branch
  • Synced GitHub ID's and paths across the PHP-8.2, PHP-8.3 and master branches

@petk petk requested review from iluuu1994 and TimWolla as code owners July 18, 2024 18:45
@TimWolla TimWolla removed their request for review July 18, 2024 18:47
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

petk added 3 commits July 24, 2024 00:16
This repeats the sync as noted in the phpGH-13591 and the discussion
https://news-web.php.net/php.internals/124472

The CODEOWNERS file is related to the targeted branch in the pull
request and not only the master branch.

- CS style comments synced (80 columns length)
- Added a note to change the earliest supported PHP branch and not only
  master branch
- Synced GitHub ID's and paths across the PHP-8.2, PHP-8.3 and master
  branches
- Revert "in a particular area" to "over a particular area"
grammar/contextual fix

- Add note how changes here should be analogous to bug fixes

[skip ci]
@petk petk force-pushed the patch-8.2-codeowners branch from d55f405 to d914e85 Compare July 23, 2024 22:20
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, let's merge this!

@petk petk merged commit d214a35 into php:PHP-8.2 Jul 28, 2024
2 checks passed
@petk petk deleted the patch-8.2-codeowners branch July 28, 2024 22:11
petk added a commit that referenced this pull request Jul 28, 2024
* PHP-8.2:
  [skip ci] Sync CODEOWNERS (#15017)
petk added a commit that referenced this pull request Jul 28, 2024
* PHP-8.3:
  [skip ci] Sync CODEOWNERS (#15017)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants