-
Notifications
You must be signed in to change notification settings - Fork 7.8k
[skip ci] Sync CODEOWNERS #15017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[skip ci] Sync CODEOWNERS #15017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
reviewed
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
This repeats the sync as noted in the phpGH-13591 and the discussion https://news-web.php.net/php.internals/124472 The CODEOWNERS file is related to the targeted branch in the pull request and not only the master branch. - CS style comments synced (80 columns length) - Added a note to change the earliest supported PHP branch and not only master branch - Synced GitHub ID's and paths across the PHP-8.2, PHP-8.3 and master branches
- Revert "in a particular area" to "over a particular area" grammar/contextual fix - Add note how changes here should be analogous to bug fixes [skip ci]
d55f405
to
d914e85
Compare
nielsdos
approved these changes
Jul 28, 2024
cmb69
approved these changes
Jul 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, let's merge this!
petk
added a commit
that referenced
this pull request
Jul 28, 2024
* PHP-8.2: [skip ci] Sync CODEOWNERS (#15017)
petk
added a commit
that referenced
this pull request
Jul 28, 2024
* PHP-8.3: [skip ci] Sync CODEOWNERS (#15017)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repeats the sync as noted in the GH-13591 and the discussion https://news-web.php.net/php.internals/124472
The CODEOWNERS file is related to the targeted branch in the pull request and not only the master branch.