Add parameter naming guidelines to CODING_STANDARDS.md #5897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to php/php-tasks#16 |
Nyholm
reviewed
Jul 28, 2020
65 tasks
|
There's probably more we could also say, but this is a good start. |
dtakken
force-pushed
the
extend-coding-standards
branch
from
f0e14a0 to
d1480ff
Compare
|
Rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that parameter names have become a serious matter I guess extending
CODING_STANDARDS.mdmay be useful. It may help in the effort to review / improve current parameter names before 8.0 is released.Does this text properly reflect the current common practice of argument naming?