Skip to content

Consistent named param: Extension Tracker #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
64 of 65 tasks
Girgias opened this issue Sep 14, 2020 · 8 comments
Closed
64 of 65 tasks

Consistent named param: Extension Tracker #23

Girgias opened this issue Sep 14, 2020 · 8 comments

Comments

@Girgias
Copy link
Member

Girgias commented Sep 14, 2020 •
edited by nikic
Loading

This is a tracker to see which extensions have been reviewed in regards to #16

Unresolved questions:
@TysonAndre TysonAndre mentioned this issue Sep 17, 2020
Closed
@remicollet
Copy link
Member

remicollet commented Sep 23, 2020 •
edited
Loading

Checked zip, consistency fixed in php/php-src@dafc72c

@remicollet
Copy link
Member

As a side note, this also means php documentation probably needs a big update, so the parameters name describe there matches actual one in 8

Done for zip in php/doc-en@462e369 and php/doc-en@002b7dd

@kocsismate
Copy link
Member

kocsismate commented Sep 23, 2020 •
edited
Loading

@remicollet Yes, we have already started working on (at least making it possible to) automatically generate function signatures for the manual.

And later we should change the parameter names in the descriptions as well.

@cmb69
Copy link
Member

cmb69 commented Sep 23, 2020

And later we should change the parameter names in the descriptions as well.

That should be done as soon as the signatures are changed in the manual. :)

@kocsismate
Copy link
Member

That should be done as soon as the signatures are changed in the manual. :)

True :) I messed up the timeline ^^ Should have said "afterwards" or "right after"

@dtakken dtakken mentioned this issue Sep 24, 2020
Closed
@dtakken
Copy link

dtakken commented Sep 25, 2020

Related PR to update the coding standards to include parameter names:

php/php-src/pull/5897

@azjezz azjezz mentioned this issue Oct 1, 2020
Merged
@cmb69 cmb69 mentioned this issue Oct 7, 2020
Closed
@Crell
Copy link

Crell commented Oct 9, 2020 •
edited
Loading

PR for pgsql: php/php-src#6304

Waiting to see if it passes tests... 😅

@nikic
Copy link
Member

nikic commented Oct 21, 2020

I believe we're done here.

@nikic nikic closed this as completed Oct 21, 2020
nicolas-grekas added a commit to symfony/polyfill that referenced this issue Oct 23, 2020
@nicolas-grekas
bug #287 Fix the name of arguments for PHP 8 (azjezz)
ac41071 
This PR was merged into the 1.19-dev branch.

Discussion
----------

Fix the name of arguments for PHP 8

With PHP 8 coming, we need to have function/methods parameters names consistent between polyfills and the original implementations.

I'm not sure if this is all of it yet.

see:
php/php-tasks#23
php/php-tasks#16

Commits
-------

f75e14e Fix the name of arguments for PHP 8
@KacerCZ KacerCZ mentioned this issue Jan 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@nikic @Crell @remicollet @dtakken @cmb69 @kocsismate @Girgias