Update fileinfo names #6206
Closed
Update fileinfo names #6206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 tasks
kocsismate
approved these changes
Sep 24, 2020
What do you think about calling it |
Exactly what I had in mind :) (besides |
nikic
force-pushed
the
fileinfo-names
branch
from
7210dfc to
c5adbe1
Compare
kocsismate
reviewed
Sep 24, 2020
| } | ||
|
|
||
| /** @return resource|false */ | ||
| function finfo_open(int $options = FILEINFO_NONE, string $arg = "") {} | ||
| function finfo_open(int $flags = FILEINFO_NONE, string $magic_database = "") {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalizing $file_name to $filename, $options -> $flags (which works particularly well here, because the function names actually use "flags") and $arg -> $magic_file (following docs here).
I first changed
$contextto$stream_context, but then changed it back, because we use$contexteverywhere else. The only usage of$stream_contextis in hash_update_file(), which already has a different$contextparameter.