Rename PDO parameters. #6220
Closed
Rename PDO parameters. #6220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 tasks
kocsismate
reviewed
Sep 27, 2020
|
|
||
| /** @return bool */ | ||
| public function bindParam(string|int $parameter, mixed &$param, int $type = PDO::PARAM_STR, int $maxlen = 0, mixed $driverdata = null) {} | ||
| public function bindParam(string|int $param, mixed &$bind_var, int $type = PDO::PARAM_STR, int $max_length = 0, mixed $driver_options = null) {} |
There was a problem hiding this comment.
I could also imagine $var instead of $bind_var
There was a problem hiding this comment.
I could be convinced of that if others feel strongly. I felt "var" was too generic, and when writing it in named form bind_var seemed more descriptive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$passwd/$password.$driverdata/$driver_optionsto match docs.$class_name/$class, as we've done elsewhere.$paraminstead of$parameter.$ctor_argsbecause really?$fetch_style/$fetch_modeon the latter, since there is asetFetchModemethod. Except in cases where "fetch" is already in the method name, then just use$mode. (I'm unsure about this one.)