Review parameter names in ext/ftp #6254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 tasks
kocsismate
commented
Oct 1, 2020
dtakken
reviewed
Oct 1, 2020
nikic
reviewed
Oct 2, 2020
nikic
reviewed
Oct 2, 2020
ext/ftp/ftp.stub.php
Outdated
| */ | ||
| function ftp_fget($ftp, $fp, string $remote_file, int $mode = FTP_BINARY, int $resumepos = 0): bool {} | ||
| function ftp_fget($ftp, $stream, string $local_filename, int $mode = FTP_BINARY, int $offset = 0): bool {} |
There was a problem hiding this comment.
local and remote got mixed up here :)
There was a problem hiding this comment.
Thanks for pointing out! :)
nikic
reviewed
Oct 2, 2020
nikic
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.