Renaming parameter names in ext/sqlite3 #6264
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 tasks
kocsismate
reviewed
Oct 2, 2020
|
And I see that there are lots of merge commits in the PR, so I'd suggest that you synchronize your branch with the upstream either by rebasing or by using fast-forward merge. These methods will ensure there are no unnecessary commits in your PR. |
kamil-tekiela
force-pushed
the
renaming-parameter-names
branch
2 times, most recently
from
4afea87 to
5fedc75
Compare
Crell
reviewed
Oct 3, 2020
Crell
reviewed
Oct 3, 2020
nikic
reviewed
Oct 5, 2020
nikic
reviewed
Oct 6, 2020
Update sqlite3_arginfo.h s/enableExceptions/enable BindValue uses $value $name is more appropriate
Camel-casing Update sqlite3_33_createAggregate_notcallable.phpt Co-authored-by: Nikita Popov <[email protected]> s/$argumentCount/$argCount
kamil-tekiela
force-pushed
the
renaming-parameter-names
branch
from
45e3a4f to
cbd638f
Compare
nikic
reviewed
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s/ms/millisecondss/destination_db/sqlite3- should it bedestination_sqlite3?s/source_dbname/source_databases/destination_dbname/destination_databases/dbname/databases/param_number/param- same as is in PDOs/param/bind_vars/expanded/expands/column_number/index