Improve parameter names in ext/oci8 #6267
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 tasks
|
@cjbj We have a historic last chance to improve parameter names before they become part of the API due to named parameters (I referenced our DIY issue tracker for this task), so here's my stab at ext/oci8. Can you please review if these changes make sense? |
|
@kocsismate good stuff. I had a quick scan. I need to fully review the changes from skip & start to offset to make sure they are consistent. Give a day or so. |
|
@kocsismate I'm OK with this. If any test diffs occur, I'll fix them after this is merged. Thanks for the PR. |
kocsismate
commented
Oct 6, 2020
kocsismate
commented
Oct 6, 2020
nikic
reviewed
Oct 7, 2020
nikic
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.