Skip to content

Update ext/spl parameter names #6284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Update ext/spl parameter names #6284

wants to merge 4 commits into from

Conversation

nikic
Copy link
Member

@nikic nikic commented Oct 6, 2020

This was much more painless than I expected...

@nikic nikic requested a review from kocsismate October 6, 2020 13:21
@nikic nikic mentioned this pull request Oct 6, 2020
Closed
65 tasks
kocsismate
kocsismate reviewed Oct 6, 2020
View reviewed changes
Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And an additional remark:

The parameter name of the unserialize() methods are inconsistent with ext/standard's unserialize(). I'm ok with $serialized, $data, or $value as well, please choose the one you like the most. :)

@nikic
Copy link
Member Author

nikic commented Oct 7, 2020

The parameter name of the unserialize() methods are inconsistent with ext/standard's unserialize(). I'm ok with $serialized, $data, or $value as well, please choose the one you like the most. :)

I've normalized this to use $data everywhere.

@php-pulls php-pulls closed this in 68195bd Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kocsismate kocsismate kocsismate approved these changes

Assignees
No one assigned
Labels
Parameter names
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikic @kocsismate