Update ext/imap parameter names #6299
Conversation
| /** @param resource $stream_id */ | ||
| function imap_listscan($stream_id, string $ref, string $pattern, string $content): array|false {} | ||
| /** @param resource $imap */ | ||
| function imap_listscan($imap, string $reference, string $pattern, string $content): array|false {} |
There was a problem hiding this comment.
I managed to track the $ref parameter all the way down to https://github.com/uw-imap/imap/blob/22f316e36dc00e445408f7a47750b7fa9c3ce369/src/c-client/imap4r1.c#L518, and I still have no clue what it does. The docs say:
ref should normally be just the server specification as described in imap_open()
So maybe it is the "server part" of $mailbox? I have no idea.
There was a problem hiding this comment.
It looks to be another IMAP mailbox, but that doesn't make a lot of sense as we are already passing a mailbox.. I have no idea either.
| /** @param resource $stream_id */ | ||
| function imap_setflag_full($stream_id, string $sequence, string $flag, int $options = 0): bool {} | ||
| /** @param resource $imap */ | ||
| function imap_setflag_full($imap, string $sequence, string $flag, int $options = 0): bool {} |
There was a problem hiding this comment.
Dilemma: This has an integer flags argument, but also a $flag argument ... I kept the $options name to avoid confusion.
There was a problem hiding this comment.
Doesn't seem like a big problem, so I agree with the approach taken
This one was a big struggle :/