Skip to content

Update ext/phar parameter names #6307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update ext/phar parameter names #6307

wants to merge 2 commits into from

Conversation

nikic
Copy link
Member

@nikic nikic commented Oct 9, 2020

No description provided.

@nikic
Copy link
Member Author

nikic commented Oct 12, 2020

@kocsismate Any further comments on this one?

Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing which hit me in the eye is the usage of the $compression param name. It looked a bit too generic at first, and $compression_algo (or just $algo?) might be more self-expressive.

@nikic
Copy link
Member Author

nikic commented Oct 12, 2020

The only thing which hit me in the eye is the usage of the $compression param name. It looked a bit too generic at first, and $compression_algo (or just $algo?) might be more self-expressive.

I picked the $compression name, because that's what this parameter is usually called in the manual (https://www.php.net/phar.compressfiles). I'd also be fine with $compressionType or $compressionAlgo. I wouldn't use just $algo, as for some of the methods like convertToExecutable it wouldn't be clear from context.

@kocsismate
Copy link
Member

I can't decide which I like more, so please go with the one you prefer, no matter if it's $compression or my suggestions. I can't find any other issues.

@php-pulls php-pulls closed this in 82d46e3 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants