Skip to content

Port numbers management is improved (#164) #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 15, 2024
Merged

Port numbers management is improved (#164) #165

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e4c2e07
reserve_port and release_port are "pointers" to functions for a port …
dmitry-lipetsk Dec 12, 2024
85d2aa3
TestgresTests::test_the_same_port is corrected
dmitry-lipetsk Dec 12, 2024
88371d1
OsOperations::read_binary(self, filename, start_pos) is added
dmitry-lipetsk Dec 12, 2024
4fe1894
OsOperations::get_file_size(self, filename) is added
dmitry-lipetsk Dec 12, 2024
28ac425
Port numbers management is improved (#164)
dmitry-lipetsk Dec 12, 2024
663612c
PostgresNode._C_MAX_START_ATEMPTS=5 is added (+ 1 new test)
dmitry-lipetsk Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TestgresTests::test_the_same_port is corrected
  • Loading branch information
@dmitry-lipetsk
dmitry-lipetsk committed Dec 12, 2024
commit 85d2aa3917f8210dce06531b563ec34c42e6b544
14 changes: 11 additions & 3 deletions tests/test_simple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,10 +1051,18 @@ def test_parse_pg_version(self):
def test_the_same_port(self):
with get_new_node() as node:
node.init().start()
self.assertTrue(node._should_free_port)
self.assertEqual(type(node.port), int)

with get_new_node() as node2:
node2.port = node.port
node2.init().start()
with get_new_node(port=node.port) as node2:
self.assertEqual(type(node2.port), int)
self.assertEqual(node2.port, node.port)
self.assertFalse(node2._should_free_port)

with self.assertRaises(StartNodeException) as ctx:
node2.init().start()

self.assertIn("Cannot start node", str(ctx.exception))

def test_simple_with_bin_dir(self):
with get_new_node() as node:
Expand Down