Skip to content

Port numbers management is improved (#164) #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 15, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
reserve_port and release_port are "pointers" to functions for a port …
…numbers management.

This need to replace port numbers management in unit tests.
  • Loading branch information
dmitry-lipetsk committed Dec 12, 2024
commit e4c2e07b3ff0c4aa16188a60bb53f108e2d5c0ca
8 changes: 6 additions & 2 deletions testgres/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def __init__(self, version: str) -> None:
super().__init__(version)


def reserve_port():
def internal__reserve_port():
"""
Generate a new port and add it to 'bound_ports'.
"""
Expand All @@ -45,14 +45,18 @@ def reserve_port():
return port


def release_port(port):
def internal__release_port(port):
"""
Free port provided by reserve_port().
"""

bound_ports.discard(port)


reserve_port = internal__reserve_port
release_port = internal__release_port


def execute_utility(args, logfile=None, verbose=False):
"""
Execute utility (pg_ctl, pg_dump etc).
Expand Down