Cleanup and document Context::onStart. #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Plevyak <[email protected]>
PiotrSikora
reviewed
May 14, 2020
Member
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
I'm slightly confused by this change and/or description. If proxy_on_vm_start is independent of the plugin, then were does it exist?
Contributor
Author
|
The comments does not reflect a change in behavior but just clarifies the behavior. The only real change is that we default to returning 'true' if there is no proxy_on_start handler, which is in keeping with the rest of the ABI which is that these handlers are optional. |
PiotrSikora
approved these changes
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Plevyak [email protected]