Skip to content

Cleanup and document Context::onStart. #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jplevyak merged 2 commits into from
May 18, 2020
Merged

Cleanup and document Context::onStart. #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6c79d3
Cleanup and document Context::onStart.
jplevyak May 8, 2020
739e392
Merge branch 'master' into start-plugin
jplevyak May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/context.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,17 +241,18 @@ std::string ContextBase::makeRootLogPrefix(string_view vm_id) const {
//
bool ContextBase::onStart(std::shared_ptr<PluginBase> plugin) {
DeferAfterCallActions actions(this);
bool result = 0;
bool result = true;
if (wasm_->on_context_create_) {
plugin_ = plugin;
wasm_->on_context_create_(this, id_, 0);
plugin_.reset();
}
if (wasm_->on_vm_start_) {
// Do not set plugin_ as the on_vm_start handler should be independent of the plugin since the
// specific plugin which ends up calling it is not necessarily known by the Wasm module.
result =
wasm_->on_vm_start_(this, id_, static_cast<uint32_t>(wasm()->vm_configuration().size()))
.u64_ != 0;
plugin_.reset();
}
return result;
}
Expand Down