(SPIKE)(MODULES-4754) Incomplete hard teardown of powershell.exe #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- An idea here would be to use Windows APIs to inject a remote thread into powershell.exe, asking for it to exit cleanly... INSTEAD of the current approach of closing pipes from Ruby and hoping PowerShell exits properly. This approach would be a lot more forceful and has the downside of re-introducing FFI'd platform specific code that runs only on Windows. There had been some effort up to this point to remove all such code to make this module more easily support cross-platform.
Iristyle
commented
Apr 21, 2017
| @@ -46,6 +188,7 @@ def initialize(cmd, debug) | |||
| ps_args = ['-File', self.class.init_path, "\"#{named_pipe_name}\""] | |||
| ps_args << '"-EmitDebugOutput"' if debug | |||
| # @stderr should never be written to as PowerShell host redirects output | |||
| # TODO: take a fd and turn it into a handle | |||
| stdin, @stdout, @stderr, @ps_process = Open3.popen3("#{cmd} #{ps_args.join(' ')}") | |||
There was a problem hiding this comment.
A better way to do this on Windows would be to start powershell.exe through Process.create which is monkey-patched by win32-process gem, allowing immediate access to the real handle.
However, that puts the module back into the mode of supporting multiple OSes differently, which is less than ideal. (popen3 uses Rubys Process.spawn under the hood)
|
Related to #177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is totally incomplete and possibly worth abandoning depending on if MODULES-4754 can be easily repro'd.
The idea here would be to more forcefully guarantee a PowerShell process should be terminated.... but it would use Windows APIs and therefore only work on Windows.