Skip to content

(MODULES-4754) Dispose runspace on pipe close #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Iristyle
Copy link
Contributor

  • In the finally block of the Start-PipeServer listener, explicitly
    Dispose of the current loaded PowerShell runspace.

@Iristyle
Copy link
Contributor Author

Iristyle commented Apr 21, 2017

Related to #178 and #177 - only one of these should win

@Iristyle Iristyle force-pushed the ticket/master/MODULES-4754-dispose-custom-PS-host branch from f14f7e2 to 0073725 Compare April 22, 2017 00:21
 - In the finally block of the Start-PipeServer listener, explicitly
   Dispose of the current loaded PowerShell runspace.
@Iristyle Iristyle force-pushed the ticket/master/MODULES-4754-dispose-custom-PS-host branch from 0073725 to 301e89c Compare April 22, 2017 00:26
Copy link
Contributor

@glennsarti glennsarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a very safe way to force a pipe closure and not depend on lower level functions.

@glennsarti
Copy link
Contributor

@jpogran Any thoughts on this?

@glennsarti glennsarti merged commit 03839ee into puppetlabs:master May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants