Skip to content

add_load_fast_null_checks doesn't ignore CACHEs #94893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brandtbucher opened this issue Jul 16, 2022 · 0 comments
Closed

add_load_fast_null_checks doesn't ignore CACHEs #94893

brandtbucher opened this issue Jul 16, 2022 · 0 comments
Assignees
@brandtbucher
Labels
3.12 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@brandtbucher
Copy link
Member

This is another one of those cases where we could end up corrupting a CACHE that looks like a valid instruction.
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker 3.11 only security fixes 3.12 only security fixes labels Jul 16, 2022
@brandtbucher brandtbucher self-assigned this Jul 16, 2022
@brandtbucher brandtbucher removed release-blocker 3.11 only security fixes labels Jul 16, 2022
@bedevere-bot bedevere-bot mentioned this issue Jul 16, 2022
Merged
brandtbucher added a commit that referenced this issue Jul 18, 2022
@brandtbucher
GH-94893: Ignore caches when adding LOAD_FAST_CHECKs (GH-94894)
b407312
Repository owner moved this from Todo to Done in Release and Deferred blockers 🚫 Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandtbucher brandtbucher

Labels
3.12 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
Release and Deferred blockers 🚫
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandtbucher