Skip to content

GH-94893: Ignore caches when adding LOAD_FAST_CHECKs #94894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2022
Merged

GH-94893: Ignore caches when adding LOAD_FAST_CHECKs #94894

merged 2 commits into from
Jul 18, 2022

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Jul 16, 2022 •
edited by bedevere-bot
Loading

@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jul 16, 2022
@brandtbucher brandtbucher requested a review from sweeneyde July 16, 2022 05:52
@brandtbucher brandtbucher self-assigned this Jul 16, 2022
sweeneyde
sweeneyde approved these changes Jul 16, 2022
View reviewed changes
Copy link
Member

@sweeneyde sweeneyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@brandtbucher brandtbucher merged commit b407312 into python:main Jul 18, 2022
@brandtbucher brandtbucher deleted the load-fast-check-caches branch July 21, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweeneyde sweeneyde sweeneyde approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@brandtbucher brandtbucher

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandtbucher @sweeneyde @bedevere-bot