[Rails 7.0] Fix support for different index types #1002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanharan
force-pushed
the
index-types-7-0
branch
from
9acf786 to
2cf8bf6
Compare
aidanharan
changed the title
aidanharan
force-pushed
the
index-types-7-0
branch
from
2cf8bf6 to
c73656c
Compare
|
Tests are failing because of a change in Rails 7.0.2 These will be fixed by #1004 |
|
Could you please add tests for |
aidanharan
force-pushed
the
index-types-7-0
branch
from
c73656c to
e2271bd
Compare
|
@wpolicarpo Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix support for different index types.
Index types were working in Rails 6.0 but were broken in Rails 6.1 by rails/rails#39203. The issue was identified in #999 for Rails 6.1.
This PR is for Rails 7.0. The fix will be backported to the
6-1-stablebranch after it is merged intomain.