Skip to content

Dump the precision for datetime columns following the new defaults #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Feb 9, 2022

The CI is failing following the release of Rails 7.0.2, see https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/runs/5123050136?check_suite_focus=true:

SchemaDumperTestSQLServer#test_0002_sst_datatypes_migration [/activerecord-sqlserver-adapter/test/cases/schema_dumper_test_sqlserver.rb:82]:
Precision of 6 not found in:
t.datetime "datetime_col".
Expected: 6
  Actual: nil

The test is failing following rails/rails#44358. When dumping a datetime column that uses the default precision of 6, the column will now be dumped with precision nil rather than 6.

@aidanharan aidanharan marked this pull request as ready for review February 9, 2022 11:13
@aidanharan aidanharan requested a review from wpolicarpo February 9, 2022 11:13
@aidanharan aidanharan assigned aidanharan and unassigned aidanharan Feb 9, 2022
@wpolicarpo wpolicarpo merged commit b94a110 into rails-sqlserver:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants