Fix typo in README's crossProject example #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grogs
changed the title
sjrd
requested changes
Dec 3, 2017
README.md
Outdated
| @@ -19,7 +19,7 @@ If you have a `crossProject`, the setting must be used only in the JS part: | |||
| ```scala | |||
| lazy val myCross = crossProject. | |||
| ... | |||
| jsSettings.( | |||
| .jsSettings( | |||
There was a problem hiding this comment.
While you're here, and since it's relevant, you should also remove the . at the end of crossProject.. Otherwise the fixed example still doesn't compile (... notwithstanding).
sbt used to recommend the trailing-dot style in their docs, but I see that now they use the leading-dot style instead (which IMO is better).
Per code review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.