Skip to content

Fix typo in README's crossProject example #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2017
Merged

Fix typo in README's crossProject example #41

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa543b8
Fix typo in crossProject example
Grogs Dec 2, 2017
9efdb05
Make README example more valid
Grogs Dec 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ If you have a `crossProject`, the setting must be used only in the JS part:
```scala
lazy val myCross = crossProject.
...
jsSettings.(
.jsSettings(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, and since it's relevant, you should also remove the . at the end of crossProject.. Otherwise the fixed example still doesn't compile (... notwithstanding).

sbt used to recommend the trailing-dot style in their docs, but I see that now they use the leading-dot style instead (which IMO is better).

libraryDependencies += "org.scala-js" %%% "scalajs-java-time" % "0.2.3"
)
```
Expand Down