Implement NVD3.js #193
Closed
Implement NVD3.js #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice work! This looks good to me. The only issue I really see is that you can't click on the tooltips in the complexity graph. Also, it might make sense to get this into the 1.2 branch instead of the master branch so that it can be part of the next minor release. @sebastianbergmann: what do you think? |
Owner
|
I think this should go into the 1.2 branch, too. |
Contributor
|
@tombevers, would you mind opening a new pull request against the 1.2 branch? |
Contributor
|
@tombevers bump :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements NVD3.js in favor of highcharts due to a license conflict.
This solves following issue: #192