Implement NVD3.js #194
Merged
Implement NVD3.js #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks, @tombevers! |
Owner
|
Thanks! It would be great if you could verify that I did not break anything when I merged this into |
Contributor
Author
|
@sebastianbergmann I'll take a look |
Contributor
Author
|
@sebastianbergmann Everything seems to be correct on the master branch. |
Owner
|
Thank you for checking! |
|
Thanks for this @tombevers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements NVD3.js in favor of highcharts due to a license conflict.
This solves following issue: #192
This was asked to be implemented on the 1.2 branch on issue #193
Sorry that it took so long before I could implement this on the 1.2 branch.