Fixed blacklist-classname for sebastian\diff #226
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpbuniat
changed the title
Contributor
|
Any reason why you made the file executable? |
Contributor
Author
|
No, .. shared folders on my box |
Contributor
|
Would you mind opening a new PR against the 2.0 branch? Also, nice catch :) |
sebastianbergmann
added a commit
that referenced
this pull request
Mar 17, 2014
Owner
|
Already taken care of. |
Contributor
|
@sebastianbergmann is too quick for us! Thanks for the PR @hpbuniat :) |
Owner
|
Sorry about that :) Thanks, @hpbuniat! |
This was referenced Mar 19, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class SebastianBergmann\Diff is not existing, which results in an error, if the autoload of zf1 is used:
Fatal error: Uncaught exception 'PHPUnit_Framework_Error_Warning' with message 'include_once(SebastianBergmann/Diff.php): failed to open stream: Datei oder Verzeichnis nicht gefunden' in Zend/Loader.php on line 134.
Although this is caused by Zend_Loader, it should be fixed by using an existing class like SebastianBergmann\Diff\Diff