Skip to content

Conversation

@hpbuniat
Copy link
Contributor

This is a follow-up to #226

The same "error" was caused by PHPUnit_Util_Blacklist, so i moved the classes to a static property, which can be used by phpunit (pull-request will be referenced).

SebastianBergmann\Comparator\Comparator is missing, as this is currently only part of the master-branch.

@sebastianbergmann
Copy link
Owner

I'd like to use this opportunity and move the list to PHPUnit and have it push it to PHP_CodeCoverage.

sebastianbergmann added a commit that referenced this pull request Mar 19, 2014
…r-2.0

Unique blacklist-classnames for php-code-coverage & phpunit
@sebastianbergmann sebastianbergmann merged commit c2c9f9d into sebastianbergmann:2.0 Mar 19, 2014
@hpbuniat
Copy link
Contributor Author

I wasn't completely sure, where it really belongs :)

@sebastianbergmann
Copy link
Owner

That is because the answer to that question is rather tricky. :-)

Before the list was duplicated in both PHPUnit and PHP_CodeCoverage. This caused the obvious problems usually associated with duplication.

Now that I have merged sebastianbergmann/phpunit#1195 and #227 that duplication is gone (good!) but PHPUnit uses a data structure that belongs to PHP_CodeCoverage (bad!).

For PHPUnit 4.1 (and PHP_CodeCoverage 2.1, respectively) I would like PHPUnit to own the list and push it into PHP_CodeCoverage. This means, of course, that a client of PHP_CodeCoverage (such as PHPUnit) is responsible for filling the default blacklist. This is not perfect either, but IMHO better than what we have now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants