Skip to content

[FrameworkBundle][Serializer] Deprecate annotations #19036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue Oct 17, 2023 · 5 comments · Fixed by #19046
Closed

[FrameworkBundle][Serializer] Deprecate annotations #19036

nicolas-grekas opened this issue Oct 17, 2023 · 5 comments · Fixed by #19046
Labels
FrameworkBundle Serializer
Milestone
6.4

Comments

@nicolas-grekas
Copy link
Member

Q A
Feature PR symfony/symfony#51470
PR author(s) @alexandre-daubois
Merged in 6.4

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 6.4 branch in the symfony-docs repository.

Thank you! 😃
@nicolas-grekas nicolas-grekas added this to the 6.4 milestone Oct 17, 2023
@alexandre-daubois alexandre-daubois mentioned this issue Oct 19, 2023
Merged
@OskarStark
Copy link
Contributor

We should remove it in 7.0 entirely, WDYT @nicolas-grekas ?

@OskarStark OskarStark reopened this Oct 24, 2023
@nicolas-grekas
Copy link
Member Author

In 6.4?

@OskarStark
Copy link
Contributor

Yeah its still valid and you can use it, so we "deprecated" it in #19046 but will remove any mention about AnnotationLoader in 7.0

@alexandre-daubois alexandre-daubois mentioned this issue Oct 24, 2023
Merged
OskarStark added a commit that referenced this issue Oct 24, 2023
@OskarStark
minor #19080 [PropertyInfo][Serializer] Remove AnnotationLoader (al…
dd7776b 
…exandre-daubois)

This PR was merged into the 7.0 branch.

Discussion
----------

[PropertyInfo][Serializer] Remove `AnnotationLoader`

Fix #19036

Commits
-------

4fd1613 [PropertyInfo][Serializer] Remove `AnnotationLoader`
@xabbuh
Copy link
Member

xabbuh commented Oct 24, 2023

Is there anything else to do here?

@alexandre-daubois
Copy link
Member

It's been removed from the 7.0 doc, so I'd say no 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FrameworkBundle Serializer
Projects
None yet
Milestone
6.4
Development

Successfully merging a pull request may close this issue.

[Serializer] Deprecate annotations alexandre-daubois/symfony-docs
5 participants
@nicolas-grekas @OskarStark @xabbuh @alexandre-daubois @carsonbot