[PropertyInfo][Serializer] Remove AnnotationLoader
#19080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Oct 24, 2023
components/serializer.rst
Outdated
| Also, the | ||
| :class:`Symfony\\Component\\Serializer\\Mapping\\Loader\\AnnotationLoader` | ||
| was deprecated in Symfony 6.4. | ||
|
|
||
| .. _component-serializer-attributes-groups-annotations: |
There was a problem hiding this comment.
Suggested change
| .. _component-serializer-attributes-groups-annotations: |
There was a problem hiding this comment.
Do we have to? I think @javiereguiluz said he wanted to avoid deleting refs at some point? I remember him saying that, but it's been a while, so I could be wrong 😄
There was a problem hiding this comment.
I think it's fine in 7.0, even better would be to add a redirect here:
https://github.com/symfony/symfony-docs/blob/7.0/_build/redirection_map
There was a problem hiding this comment.
I mean, remove it and add an entry in the redirection_map
There was a problem hiding this comment.
First time touching this file, hope I updated it correctly 👍
OskarStark
reviewed
Oct 24, 2023
OskarStark
changed the title
AnnotationLoader
alexandre-daubois
force-pushed
the
remove-annotation-loader
branch
from
3c6f4d2 to
9c5d9ec
Compare
OskarStark
reviewed
Oct 24, 2023
OskarStark
reviewed
Oct 24, 2023
alexandre-daubois
force-pushed
the
remove-annotation-loader
branch
from
9c5d9ec to
4fd1613
Compare
|
Thank you Alexandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19036