This repository was archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #190
node js version should between quotation marks based on http://docs.travis-ci.com/user/languages/javascript-with-nodejs/ Closes #213
…ndex-async" command This fixes the 404 not found when it tries to retrieve this map file and can't because the path is wrong. Note that you won't see that error if you have JavaScript source maps turned off. Closes #197
Closes #229
You don't need it when doctype is HTML5 and also the others above already don't have one. Closes #232
…html` Previously, `angular-loader` was never inlined into `index-async.html`, because running `sed` with a multiline RegExp fails to match anything, since `sed` matches per line. Using the `fs` module directly, solves the issues. (Now, we no longer depend on `shelljs`.) Closes #309
When using `'...'.replace(regex, replacement)`, any instances of `$$` inside `replacement` will be converted to `$` (see [mdn](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace#Specifying_a_string_as_a_parameter). Thus, for example `$$minErr` and `$$moduleName` are converted to `$minErr` and `$moduleName`. This commit fixes it, by first using `'...'.split(regex).join(replacement)` instead. Fixes #283 Closes #286
This test refers to general end-to-end tests. Closes #235
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.